Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"terminal.ansiBlack" value ignored by integrated terminal #63699

Closed
ghost opened this issue Nov 23, 2018 · 2 comments
Closed

"terminal.ansiBlack" value ignored by integrated terminal #63699

ghost opened this issue Nov 23, 2018 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label

Comments

@ghost
Copy link

ghost commented Nov 23, 2018

  • VSCode Version: 1.29.1 (user setup), 1.30.0-insider (user setup)
  • OS Version: 10.0.17763.134

Steps to Reproduce:

  1. Set "terminal.ansiBlack" to "#ff00ff"
  2. For comparison, set "terminal.ansiRed" to "#00ff00"
  3. Open integrated terminal using WSL
  4. Execute the LDP color test (bottom of the page) in the terminal
  5. Verify that the background color for the 40m (ansiBlack) column is not set to #ff00ff
  6. To compare, verify that the background color for the 40m (ansiRed) column is set to #00ff00

Does this issue occur when all extensions are disabled?: Yes

It may make the report a little more cluttered, but I included a screenshot of WSLtty on top which shows that the color test is able to render a background for the 40m column (it’s very dark and may appear as black – hex color value is #0c0c0c).

ansi-black

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Nov 23, 2018
@ghost
Copy link
Author

ghost commented Nov 23, 2018

By the way, I understand that "editor.backgroundColor" often is set to the same value as "terminal.ansiBlack". This might not be an issue in most cases. It was however a bit surprising while editing the different colors why this particular didn’t work as expected.

@Tyriar
Copy link
Member

Tyriar commented Nov 29, 2018

This is likely related to winpty, tracking in #45693

@Tyriar Tyriar closed this as completed Nov 29, 2018
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

1 participant