Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

javascript.updateImportsOnFileMove broken on VS mac #64082

Closed
kingces95 opened this issue Nov 30, 2018 · 4 comments
Closed

javascript.updateImportsOnFileMove broken on VS mac #64082

kingces95 opened this issue Nov 30, 2018 · 4 comments
Assignees
@mjbvz
Labels
info-needed Issue requires more information from poster typescript Typescript support issues

Comments

@kingces95
Copy link

Expected behavior:
When I move a .js file I expect to be prompted to update imports.

Actual behavior:
Prompted on VS windows but not VS mac. On VS mac nothing actually happens whereas I had expected it would prompt me just like windows.

Environment
Mac
Verified using TypeScript 2.9.2 (also tried updating and restarting to load version typescript@3.3.0-dev.20181130)
VS Code 1.25.1

Windows
Verified using TypeScript 3.0.1
VS Code 1.26.1
@vscodebot vscodebot bot added the typescript Typescript support issues label Nov 30, 2018
@kingces95
Copy link
Author

Cross posted to TypeScript microsoft/TypeScript#28771.

@kingces95 kingces95 mentioned this issue Nov 30, 2018
Closed
@mjbvz
Copy link
Collaborator

mjbvz commented Nov 30, 2018

Do you see this using the latest typescript versions, 3.1.6 or 3.2.1?

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 30, 2018

Also, you are on old VS Code versions. Please update to at least 1.29.1 or, better, the latest VS Code insiders build build

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Nov 30, 2018
@kingces95
Copy link
Author

Nice. Works on the insider build with typescript@3.3.0-dev.20181130.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
info-needed Issue requires more information from poster typescript Typescript support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kingces95 @mjbvz