Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Properties contribution for CSS #64164

Closed
octref opened this issue Dec 2, 2018 · 0 comments
Closed

Custom Properties contribution for CSS #64164

octref opened this issue Dec 2, 2018 · 0 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality on-testplan

Comments

@octref
Copy link
Contributor

octref commented Dec 2, 2018

Related: #47775

Problem

  • PostCSS has plugins like postcss-size and postcss-circle that adds custom, non-standard properties

  • People working on large code bases often have their own variant of CSS, for example: Allow contributions of custom CSS properties to CSS extension #47775 (comment)

  • unknownProperties suppress diagnostic warnings, but do not provide other Language Features

    captura de pantalla 2018-09-19 a las 16 23 24

  • In CSS Language Service, we are adding more and more data from MDN. We would hope the data can be loaded separately from the app. For example:

    • createCSSLS({ propertySets: [standardProperties] }) creates a normal CSS LS
    • createCSSLS({ propertySets: [standardProperties, postcssProperties] }) creates a CSS LS that supports postcssProperties.

Solution

  • December: Similar to HTML custom tags/attributes support, we'll add css.experimental.custom.properties as a setting that allows loading extra properties through JSON
  • Planned Language Features for custom properties:
    • Completion for property / property-value
    • Hover information that shows property documentation
    • CodeAction that fixes properties typo
  • Engage with PostCSS community and other parties that need custom contributions to CSS, and look for further improvements:
    • Allow contributes.css.custom.properties as Extension Contribution
    • Allow at-rule contribution
@octref octref added feature-request Request for new features or functionality css-less-scss Issues and items concerning CSS,Less,SCSS styling labels Dec 2, 2018
@octref octref added this to the December 2018 milestone Dec 2, 2018
@octref octref self-assigned this Dec 2, 2018
@octref octref closed this as completed Jan 11, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

2 participants
@octref and others