Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search view layout in panel can be improved #64418

Closed
isidorn opened this issue Dec 5, 2018 · 5 comments
Closed

Search view layout in panel can be improved #64418

isidorn opened this issue Dec 5, 2018 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code search Search widget and operation issues ux User experience issues

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 5, 2018

screenshot 2018-12-05 at 11 36 14

  1. Notice the search and replace inline buttons all the way to the right. They look disconnected and far away
  2. Notice all the empty space on the right. This space feels unused, and I feel like we could have a better layout / presentation of results in this case
  3. Notice how the hover actions jump at the end of each line. Thus their position is not consistent. This was done so they would not be at the very end disconnected. However this does not feel like a real solution for me
  4. Notice how the snippet of each result is cropped at the same length as in the sidebar. Even though here we have much more space and could show more context of each result

I think we could give more thought to improving this experience.
Though before we do anything crazy I suggest we wait for the workbench layout using the grid - as we might need a more general story for views.
fyi @bpasero @sbatten

@isidorn isidorn added feature-request Request for new features or functionality search Search widget and operation issues labels Dec 5, 2018
@miguelsolorio miguelsolorio added the ux User experience issues label Dec 5, 2018
@roblourens
Copy link
Member

We tried some things earlier and nothing really worked. Maybe @misolori can take a crack at it some day.

  1. We do have the setting search.actionsPosition for this at least but I'm not crazy about either setting.

  2. Yeah there is another issue for this.

@miguelsolorio
Copy link
Contributor

@roblourens if you have any screenshots of what's been tried before that'd be great (so we don't repeat ourselves 😝)

@roblourens
Copy link
Member

Here is the issue with screenshots: #45063

@andremacola
Copy link

Related to #23931

@miguelsolorio miguelsolorio mentioned this issue Jan 9, 2019
33 tasks
@roblourens
Copy link
Member

Probably will focus on search results in a text editor rather than this

@roblourens roblourens added the *out-of-scope Posted issue is not in scope of VS Code label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code search Search widget and operation issues ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants