Clicking on collapsed debug session stack expands then collapses it immediately

[roblourens]

• Just debugging two normal sessions
• A is active, B is collapsed
• Click B, it blinks open then collapses again

I'm guessing it's toggled by the click and by becoming active and they interfere?

[isidorn]

The issue here is the following:
There is a tree navigator, which will react on click -> based on that reaction I will call tree.expand
However while I am doing this the tree plans to toggle expansion because of the click. My expand gets resovled first, which expands the element and than the tree collapses it.

@joaomoreno on advice what best to do here

[joaomoreno]

There is a tree navigator, which will react on click -> based on that reaction I will call tree.expand

Why are we calling expand there?

[isidorn]

Because of the way my code is strucutred, whenever a stack frame gets focused I want to expand the session and the thread to show the stack frame.

So what happens here is a weird cycle. Click on sessions, session due to navigator gets focused, because session gets focused we find a stack frame belonging to it and it gets focus and the expand happens

[roblourens]

The workaround of keeping a flag on the callstack's side is awkward and would be nicer if we could pass some context through the setFocus call in the tree like the old tree allows.

[joaomoreno]

New tree allows that too.

[isidorn]

Does not apply in this use case.
But thanks for the advice, however for now I will go with the workaround.

[roblourens]

The browserEvent? https://github.com/Microsoft/vscode/blob/master/src/vs/base/browser/ui/tree/abstractTree.ts#L361 For search, I'm looking for a way to pass some arbitrary flag in, although I could pack it into a fake browser event.

[joaomoreno]

Yeah the browser event... I'm not too keen on allowing any there. What is the use case exactly for search?

[roblourens]

I opened #64743