Toggle Integrated Terminal doesn't work in latest release (insiders)

[bengry]

Issue Type: Bug

1. Install the latest insiders release (1.31.0-insider -- ece3a90).
   (Update: still happens with latest insiders - d85a16f)
2. Press "Ctrl+`" or via the Command Palette -> "Toggle Integrated Terminal" / Ctrl+`.
3. Nothing happens.

In VS Code (non insiders) everything works as expected - with the integrated terminal being shown and hidden with every key press.

VS Code version: Code - Insiders 1.31.0-insider (ece3a90, 2018-12-14T06:13:54.375Z)
OS version: Darwin x64 18.2.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz (8 x 3100)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 10, 10
Memory (System)	16.00GB (1.89GB free)
Process Argv
Screen Reader	no
VM	15%

Extensions (45)

Extension	Author (truncated)	Version
output-colorizer	IBM	0.1.2
ActiveFileInStatusBar	Ros	1.0.3
vscode-file-peek	abi	1.0.1
markdown-toc	Ala	1.5.6
Bookmarks	ale	10.0.0
ng-template	Ang	0.1.11
bracket-pair-colorizer	Coe	1.0.61
language-postcss	cpy	1.0.5
gitlens	eam	9.2.0
EditorConfig	Edi	0.12.5
tslint	eg2	1.0.41
prettier-vscode	esb	1.7.2
nasc-touchbar	fel	1.11.0
vscode-pull-request-github	Git	0.3.2
path-autocomplete	ion	1.13.1
RelativePath	jak	1.4.0
hungry-delete	jas	1.5.0
search-node-modules	jas	1.3.0
svg	joc	0.1.4
docthis	joe	0.7.1
expand-region	let	0.1.2
Angular-BeastCode	Mik	7.0.20
vscode-scss	mrm	0.6.2
vsliveshare	ms-	0.3.1071
debugger-for-chrome	msj	4.11.1
angular2-inline	nat	0.0.17
copy-json-path	nid	0.0.5
vscode-jest	Ort	2.9.2
vscode-versionlens	pfl	0.22.0
debug-current	phi	0.1.0
nested-comments	phi	2.2.6
classlens	rex	0.7.1
postcss	ric	2.0.0
partial-diff	ryu	1.4.0
code-settings-sync	Sha	3.2.4
guides	spy	0.9.2
code-spell-checker	str	1.6.10
vscode-status-bar-format-toggle	tom	1.4.0
sensitive-replace	vil	0.1.1
vscodeintellicode	Vis	1.1.2
quokka-vscode	Wal	1.0.174
vscode-todo-highlight	way	1.0.4
change-case	wma	1.0.0
map-replace-js	Yuk	0.1.0
html-css-class-completion	Zig	1.17.1

(1 theme extensions excluded)

[bengry]

@Tyriar please advise here - I didn't see any activity here. Still happens with the latest insiders build (d315b31).

[Tyriar]

@bengry I can't reproduce, is there anything in devtools console? (Help > Toggle Developer Tools)

[bengry]

@Tyriar Just checked - no new messages in the devtools console when pressing Ctrl+` (also edited the OP, I wrote there cmd instead of ctrl, even though I always meant ctrl, sorry for the confusion).
I also tried disabling all of my extensions, just in case - still the same.

I do want to add that when choosing "Toggle integrated terminal" from the command palette, it does pop up the terminal, but not back down, the keystroke does nothing at all, ever. I do still have the same bindings in place, so it should work just the same:

Also tried to rename the following directories, to get a "fresh install" of VSC insiders, still had the same issue:

• ~/Library/Application Support/Code
• ~/Library/Application Support/Code - Insiders
• ~/.vscode
• ~/.vscode-insiders

---

Update - I think I found the culprit - @Tyriar did the keyboard layout detection changed, or something along those lines? I went to the keyboard preferences to try and change the keystroke for the integrated terminal to see if that would solve it, to my surprise - it did. Then I tried to change it back to Ctrl+`, but it showed me this in the insiders builds (ignore the scratched-out red, those were the keystrokes to toggle the screenshot):

Settings this solved it for me. I then went to VSC (non insiders) to try it there too (they share the same settings file I suppose?) - and there i got the regular Ctrl+`, pressing the exact same keys:

I use macOS, with the "ABC" keyboard layout, in case that matters:

P.S.
I also tried to then press Ctrl+§ on my keyboard - that registered as a Ctrl+` in VSC insiders (and Ctrl+§ in VSC).

[rebornix]

@bengry do you happen to have extension page open? I have a feeling it shares the same root cause as #64724

[bengry]

@rebornix Do you mean this page?:

If so, I just tried it both with it, and on a random file being open - same issue in both cases, with it not triggering anything.

I don't think it's related to it being trigged twice - but rather that Electron/VSC somehow using a different layout of the keys than the system's or something along those lines. If you look at my earlier comment, when I went to change the keybinding, then a) it worked just fine with any other key combination. b) it detected my keyboard's '`' key (which also shares '~' - this is the UK/European model of the MBP) as a § (which in my case is right next to the number bar, and shares it with ±). That's why I think the layout is the matter here.

I also tried one more thing - open devtools in both vsc and vsc insiders (latest version of each), and then:

1. run the following snippet: document.addEventListener('keydown', e => console.log(e))
2. Press Ctrl+` in my keyboard inside VSC/VSC insiders
   Here are the results:
   VSC:
   

VSC Insiders:

The key is the same in both, but the code changed. Probably due to the new Electron (and thus Chromium) version. I think that changed a while ago though, so not sure what happened in the last week or so that changed this.

Maybe related to: #24153, #65082.

[alexdima]

With our move to Electron 3.0, we have lost the patch that removes the Chromium key swap on ISO keyboards

[bpasero]

@bengry can you try to reproduce with todays insider build?

[bpasero]

Closing as duplicate of #65082

[bengry]

@bpasero working after today's insiders build. Thanks!