Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANSI coloring is off in DOM-based terminal #65172

Closed
brunnerh opened this issue Dec 16, 2018 · 1 comment
Closed

ANSI coloring is off in DOM-based terminal #65172

brunnerh opened this issue Dec 16, 2018 · 1 comment
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s) upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@brunnerh
Copy link

Issue Type: Bug

The displayed colors do not match the expected colors. If one prints 360 hue values at full saturation and middle lightness (i.e. the fully saturated color wheel) one of the lines gets assigned the xterm-fg-0 class, which is black. The colors are supposed to get lighter at that point so that makes little sense to me:

image

gnome-terminal for reference:

image

VS Code version: Code 1.30.0 (c6e592b, 2018-12-11T22:21:33.585Z)
OS version: Linux x64 4.18.7-arch1-1-ARCH
@Tyriar
Copy link
Member

Tyriar commented Dec 17, 2018

Tracked in xtermjs/xterm.js#484

@Tyriar Tyriar closed this as completed Dec 17, 2018
@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) *duplicate Issue identified as a duplicate of another issue(s) labels Dec 17, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s) upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brunnerh @Tyriar