Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad TS syntax coloring #65211

Closed
joaomoreno opened this issue Dec 17, 2018 · 1 comment
Closed

Bad TS syntax coloring #65211

joaomoreno opened this issue Dec 17, 2018 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded

Comments

@joaomoreno
Copy link
Member

Check out asyncDataTree.ts:535 in 419d5bbaedebef63cff9bc248f8407cda5d40562.

Coloring seems broken:

screenshot from 2018-12-17 15-44-35

Funnily enough, Github's syntax colorer has exactly the same issue: https://github.com/Microsoft/vscode/blob/419d5bbaedebef63cff9bc248f8407cda5d40562/src/vs/base/browser/ui/tree/asyncDataTree.ts#L535
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar labels Dec 17, 2018
@mjbvz mjbvz mentioned this issue Dec 17, 2018
Closed
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 17, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 17, 2018

Opened microsoft/TypeScript-TmLanguage#698 to track this upstream

@mjbvz mjbvz closed this as completed Dec 17, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 1, 2019
@joaomoreno joaomoreno added the verified Verification succeeded label Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaomoreno @mjbvz