Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile to ES6 #65372

Closed
2 of 3 tasks
jrieken opened this issue Dec 19, 2018 · 2 comments
Closed
2 of 3 tasks

Compile to ES6 #65372

jrieken opened this issue Dec 19, 2018 · 2 comments
Assignees
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Dec 19, 2018

This is the continuation of #47144. The goal is to down level compile the VS Code sources to modern JS so that we benefit from things like let, const, async/await and more. Things that need to be done:

  • Adjust our compile scripts - reuse from Compile down to es6 #47144?
  • Make sure that we don't leak modern library dependencies into the monaco-editor and layers below. This is because of our old friend IE11. Our fix for this is the double compile via tsconfig.monaco.json
  • With es6 classes will be emitted as classes. This breaks extensions that are extending from our classes that are compiled to functions (see Compile down to es6 #47144 (comment))

cc @joaomoreno

@jrieken jrieken self-assigned this Dec 19, 2018
@jrieken jrieken added debt Code quality issues engineering VS Code - Build / issue tracking / etc. labels Dec 19, 2018
@jrieken jrieken mentioned this issue Feb 7, 2019
@jrieken
Copy link
Member Author

jrieken commented Feb 7, 2019

some work is happening here: #68121

@jrieken jrieken added this to the February 2019 milestone Feb 11, 2019
@jrieken
Copy link
Member Author

jrieken commented Feb 11, 2019

This is now in master.

@jrieken jrieken closed this as completed Feb 11, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

1 participant