Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume control keys typed in terminal #65949

Closed
galich opened this issue Jan 3, 2019 · 2 comments
Closed

Volume control keys typed in terminal #65949

galich opened this issue Jan 3, 2019 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone
December/January ...

Comments

@galich
Copy link

galich commented Jan 3, 2019

Pressing volume buttons on Microsoft Surface Keyboard when Visual Studio Code Insiders terminal is focused produces fun results:

image

Version: 1.31.0-insider (user setup)
Commit: ed5363e
Date: 2019-01-02T17:25:53.371Z
Electron: 3.0.10
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Jan 3, 2019
@Tyriar
Copy link
Member

Tyriar commented Jan 4, 2019

😆 Thanks for the quick feedback, this was caused by xtermjs/xterm.js#1849

@Tyriar Tyriar added this to the December/January 2019 milestone Jan 4, 2019
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Jan 4, 2019
This was referenced Jan 4, 2019
Closed
Closed
@Tyriar Tyriar closed this as completed in bbcc0f6 Jan 4, 2019
@joaomoreno
Copy link
Member

Thanks! 🙏

@joaomoreno joaomoreno added the verified Verification succeeded label Jan 4, 2019
This was referenced Jan 4, 2019
Closed
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
December/January 2019
Development

No branches or pull requests
3 participants
@joaomoreno @Tyriar @galich