Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting failure on C++ UDL with ' #67161

Closed
mpusz opened this issue Jan 26, 2019 · 4 comments
Closed

Syntax highlighting failure on C++ UDL with ' #67161

mpusz opened this issue Jan 26, 2019 · 4 comments
Assignees
Labels
grammar Syntax highlighting grammar
Milestone

Comments

@mpusz
Copy link

mpusz commented Jan 26, 2019

Issue Type: Bug

If UDL uses ' signs to separate parts of the number like here:
static_assert(3.2_GHz == 3'200'000'000_Hz);
than the code highlighting is lost until the end of the file.

You can find the exact code here:
https://github.com/mpusz/units/blob/master/test/test_units.cpp

VS Code version: Code 1.30.2 (61122f8, 2019-01-07T22:54:13.295Z)
OS version: Windows_NT x64 10.0.17763

System Info
Item Value
CPUs Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz (8 x 1896)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.38GB (5.60GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (9)
Extension Author (truncated) Version
gc-excelviewer Gra 2.1.28
autoconf mae 0.0.7
python ms- 2018.12.1
cpptools ms- 0.21.0
vsliveshare ms- 0.3.1136
vsliveshare-audio ms- 0.1.48
vsliveshare-pack ms- 0.2.5
cmake twx 0.0.17
cmake-tools vec 1.1.3
@DrPizza
Copy link

DrPizza commented Feb 21, 2019

This is very debilitating, as a number of my source files are substantially string coloured.

@sean-mcmanus
Copy link
Contributor

The root cause is being tracked at atom/language-c#127 . Can you upvote that? If #68392 is fixed then maybe we could get a fix that way.

@sean-mcmanus
Copy link
Contributor

FYI, the "Better C++ Syntax" extension just added support for this. If you could try out that extensions and let the author know if you find any issues with it that would be great.

@aeschli aeschli assigned alexr00 and unassigned aeschli Feb 26, 2019
@alexr00 alexr00 added this to the March 2019 milestone Feb 26, 2019
@alexr00 alexr00 added the grammar Syntax highlighting grammar label Feb 26, 2019
@alexr00
Copy link
Member

alexr00 commented Mar 4, 2019

We've switched to a different grammar for C++ and it looks like it fixed this issue! @jeff-hykin thanks for fixing this.

@alexr00 alexr00 closed this as completed Mar 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar
Projects
None yet
Development

No branches or pull requests

5 participants