Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions.all does not correctly update when extensions.onDidChange fires #68379

Closed
golf1052 opened this issue Feb 10, 2019 · 6 comments
Closed
Assignees
Labels
extensions Issues concerning extensions info-needed Issue requires more information from poster

Comments

@golf1052
Copy link
Member

  • VSCode Version: 1.31.0
  • OS Version: Windows 10 1809 (build 17763.253)

Steps to Reproduce using an extension that is listening to extensions.onDidChange

  1. Store list of extensions.all
  2. Disable an extension
  3. When onDidChange fires the extension will not be in the list of extensions.all (comparing the two lists)
  4. Re-enable the same extension.
  5. When onDidChange fires not that the extension will still not be in the extensions.all list.

The above steps also works for uninstalling then reinstalling an extension. I've tested this with Polacode (a non theme extension) and a theme extension.

Does this issue occur when all extensions are disabled?: No as this is related to extensions.

Related issues: #14444

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Feb 10, 2019
@sandy081
Copy link
Member

@golf1052 When you disabled the extension, does it show a reload is required?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Feb 12, 2019
@golf1052
Copy link
Member Author

No for both extensions it did not prompt for a reload.

@sandy081
Copy link
Member

May I know the extensions you are trying to disable?

@golf1052
Copy link
Member Author

Polacode and Eva Theme

@sandy081
Copy link
Member

@golf1052 I tried with a simple example

'use strict';

import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
    vscode.extensions.onDidChange(() => {
        vscode.extensions.all.forEach(e => console.log(e.id));
    });
}

Disabling the extension - Disabled extension is not there in the list
Enabling the extension - Enabled extension is in the list

@vscodebot vscodebot bot closed this as completed Mar 8, 2019
@vscodebot
Copy link

vscodebot bot commented Mar 8, 2019

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants