Files to exclude being ignored

[shaehn]

Issue Type: Bug

It appears that node_modules folder is still being searched even with the exclude pattern set in user settings set at **/node_modules. I searched for the word DEVELOPER and was getting hits in files under the node_modules folder.

Hmm... this appears to be similar to #46718

VS Code version: Code 1.31.0 (7c66f58, 2019-02-05T22:35:56.624Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7 CPU 920 @ 2.67GHz (8 x 2660)
GPU Status	2d_canvas: disabled_software checker_imaging: disabled_off flash_3d: disabled_software flash_stage3d: disabled_software flash_stage3d_baseline: disabled_software gpu_compositing: disabled_software multiple_raster_threads: disabled_off native_gpu_memory_buffers: disabled_software rasterization: disabled_software surface_synchronization: disabled_off video_decode: disabled_software webgl: disabled_off webgl2: disabled_off
Memory (System)	15.99GB (7.17GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (7)

Extension	Author (truncated)	Version
Bookmarks	ale	10.2.2
alignment	ann	0.3.0
solargraph	cas	0.19.3
rainbow-csv	mec	1.0.0
debugger-for-chrome	msj	4.11.1
ruby	reb	0.21.0
vscode-icons	rob	8.1.0

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• search.exclude does not work for searching symbols across a workspace (#46718)
• VS Code freezes when removing 'node_modules' folder from external terminal, forcing to close (#20480)
• Sidebar view doesn't show subdiretory of a exluded dir in files.exclude (#67884)
• Cannot delete node_modules/@types (#61829)

[imcotton]

This happens on v1.31.1 as well.

[burtek]

Same here.

[roblourens]

@burtek you have toggled off the button to use exclude settings, please click the button in the "files to exclude" box.

Others please check whether you've done the same. Or see the wiki page for troubleshooting tips https://github.com/Microsoft/vscode/wiki/Search-Issues

[imcotton]

@robertohuertasm

By changing the setting of search.quickOpen.includeHistory from default true to false fixed issue to me, so my reproduction were:

1. Leaving search.quickOpen.includeHistory as default setting as true
2. Open one file manually which in the excluding list (e.g.: node_modules/foobar/dist/index.min.js)
3. Close that tab
4. Bring up Quick Open view and searching for index
5. node_modules/foobar/dist/index.min.js shows up in the list of quick open as recently opening

I recall that step 5 was not the case in any of previous versions, seems behavior changed a little here.

[shaehn]

@burtek That was indeed my problem. The interface is subtle, different from what I have encountered elsewhere. Usually one expects a check mark somewhere, as opposed to a lightly colored rectangle to indicate on/off.