Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid 'integratedTerminal' and 'externalTerminal'. Rather use 'terminal' #6859

Closed
aeschli opened this issue May 25, 2016 · 3 comments
Closed
Assignees
Labels
terminal General terminal issues that don't fall under another label
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented May 25, 2016

For #6654.
Right now the settings are called
"integratedTerminal.shell.linux": "/bin/bash"
"externalTerminal.windowsExec": "cmd",

If you look at other settings, we avoid camelcase in the first segment.
I'd suggest to group everything under terminal.

-> One setting that chooses which terminal type to use (e.g. when invoking 'Open in terminal').
'external', 'integrated'. IMO intergrated should be the default.
-> terminal.external.windowExec ...
-> terminal.integrated.shell

@Tyriar Tyriar added the terminal General terminal issues that don't fall under another label label May 27, 2016
@Tyriar Tyriar added this to the May 2016 milestone May 27, 2016
@Tyriar
Copy link
Member

Tyriar commented May 27, 2016

I like it

@Tyriar Tyriar closed this as completed in 1dfc347 May 27, 2016
@Tyriar
Copy link
Member

Tyriar commented May 27, 2016

8c1dff7

@Tyriar
Copy link
Member

Tyriar commented May 27, 2016

@Tyriar Tyriar assigned aeschli and unassigned Tyriar May 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

2 participants