You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also consider renaming pattern to portPattern since the pattern property only captures the port looking at the description.
Unless there are plans in the future to extend this property to more.
I prefer serverReadyAction over onServerReady because most users are not used to the VS Code naming conventions. In addition serverReadyAction sets a context for the action attribute that follows.
pattern: No, the pattern covers both ports or URIs.
openExternally: end user features don't have to match grammatically incorrect developer API names (and most users are not VS Code extension developers).
Refs: #69313
Just personal preference, but I prefer onServerReady since it sounds more like what it does -> that we actually do something when the server is ready.
The text was updated successfully, but these errors were encountered: