Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming serverReadyAction -> onServerReady #69342

Closed
isidorn opened this issue Feb 25, 2019 · 3 comments
Closed

Consider renaming serverReadyAction -> onServerReady #69342

isidorn opened this issue Feb 25, 2019 · 3 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues polish Cleanup and polish issue
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 25, 2019

Refs: #69313

Just personal preference, but I prefer onServerReady since it sounds more like what it does -> that we actually do something when the server is ready.

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues polish Cleanup and polish issue labels Feb 25, 2019
@isidorn
Copy link
Contributor Author

isidorn commented Feb 25, 2019

Also consider renaming pattern to portPattern since the pattern property only captures the port looking at the description.
Unless there are plans in the future to extend this property to more.

@isidorn
Copy link
Contributor Author

isidorn commented Feb 25, 2019

Also consider to change openExternally to openExternal since that is the name that we use in our vscode.d.ts https://github.com/Microsoft/vscode/blob/393b48d4a5de85b6fa1d2ad0a59588d6715e12ea/src/vs/vscode.d.ts#L5969

@weinand
Copy link
Contributor

weinand commented Feb 25, 2019

  • I prefer serverReadyAction over onServerReady because most users are not used to the VS Code naming conventions. In addition serverReadyAction sets a context for the action attribute that follows.
  • pattern: No, the pattern covers both ports or URIs.
  • openExternally: end user features don't have to match grammatically incorrect developer API names (and most users are not VS Code extension developers).

@weinand weinand added this to the March 2019 milestone Feb 26, 2019
@weinand weinand modified the milestones: March 2019, Backlog Mar 21, 2019
@weinand weinand closed this as completed Mar 21, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

2 participants