Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report tsconfig/jsconfig errors from TypeScript Server at correct location in file #69880

Closed
mjbvz opened this issue Mar 6, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verification-found Issue verification failed verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 6, 2019

From microsoft/TypeScript#10384

repo

  1. In a new project with a single ts file, create a tsconfig.json:
{
    "compilerOptions": {
        "module": "commonjs",
        "target": "es2016",
        "jsx": "preserve"
    },
    "exclude": [
        "node_modules",
    ],
    "files": []
}
  1. Make sure the js/ts extension is active by opening the TS file.
  2. Open the tsconfig.

Bug
There should be an error reported in the tsconfig about there being no input files. However this error is currently reported on the first line of the tsconfig instead of on the files entry

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues javascript JavaScript support issues labels Mar 6, 2019
@mjbvz mjbvz added this to the March 2019 milestone Mar 6, 2019
@mjbvz mjbvz self-assigned this Mar 6, 2019
@mjbvz mjbvz closed this as completed in 38c3f4b Mar 6, 2019
@alexr00
Copy link
Member

alexr00 commented Mar 27, 2019

I was able to reproduce in stable, but in insiders I don't see the error reported anywhere. It is not in the problems panel and nothing is red-squiggled in the tsconfig.json. I made sure to open the .ts file, and I could see the status bar info about the typescript language features initializing.

@mjbvz
Copy link
Collaborator Author

mjbvz commented Mar 28, 2019

Opened microsoft/TypeScript#30623 for root cause of these not showing up in the first place. To test diagnostic location, please try making an edit to the config file and saving it

@mjbvz mjbvz closed this as completed Mar 28, 2019
@alexr00 alexr00 added the verified Verification succeeded label Mar 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants