Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions view/editor should have a open settings editor for that extension #70959

Closed
jrieken opened this issue Mar 22, 2019 · 5 comments
Closed
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality

Comments

@jrieken
Copy link
Member

jrieken commented Mar 22, 2019

As part of #41882 (comment) we open the extensions viewlet with the intention that user disable/configure formatter extensions. Disablement is already very prominent but there is no configure-link from an extension.

The idea is to:

  • have a configure...-action in the context of an extension - @sandy081
  • have a way to open the settings editor so that it only shows the settings of an extension (this is similar to @id:my.ext and the extensions viewlet) - @roblourens

Screenshot 2019-03-22 at 15 07 45

@jrieken
Copy link
Member Author

jrieken commented Mar 22, 2019

cc @aeschli

@sandy081 sandy081 added api extensions Issues concerning extensions and removed api labels Mar 22, 2019
@sandy081
Copy link
Member

Duplicate of #25012

@sandy081 sandy081 marked this as a duplicate of #25012 Mar 22, 2019
@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 22, 2019
@vscodebot
Copy link

vscodebot bot commented Mar 22, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Mar 22, 2019
@roblourens
Copy link
Member

I don't think it's a duplicate of #25012. That one is about editing settings inside the extension tab. @jrieken suggests that we add a filter mode for extensions and open the real settings gui with a link from the extension page. I think that's a good idea, and #25012 should probably be closed.

@roblourens roblourens reopened this Mar 22, 2019
@roblourens roblourens added feature-request Request for new features or functionality and removed *duplicate Issue identified as a duplicate of another issue(s) labels Mar 22, 2019
@sandy081
Copy link
Member

@roblourens #25012 also talks about the same as we concluded to open the settings editor from the extensions editor - #25012 (comment)

It was confusing because of the summary. Will update it.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants