Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Hierarchy: do not show twistie when node has no children #71141

Closed
bpasero opened this issue Mar 26, 2019 · 4 comments
Closed

Call Hierarchy: do not show twistie when node has no children #71141

bpasero opened this issue Mar 26, 2019 · 4 comments
Assignees
Labels
editor-symbols definitions, declarations, references under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 26, 2019

Refs: #71083

Currently, a node that has no children still shows a twistie. I would expect that the twistie does not show so that one understands there are no further calls below.

@jrieken jrieken added under-discussion Issue is under discussion for relevance, priority, approach editor-symbols definitions, declarations, references labels Mar 26, 2019
@jrieken
Copy link
Member

jrieken commented Mar 26, 2019

show so that one understands there are no further calls below

For once there is technical challenge, when being (synchronously) being asked for children we don't know yet but then isn't this just like the explorer. That also shows twisties for empty folders

@bpasero
Copy link
Member Author

bpasero commented Mar 26, 2019

@jrieken yeah I would argue in the explorer it somewhat makes sense because the twistie is a good indicator for the thing being a folder or not.

I would only say a twistie should not be shown if you can have that knowledge when the node becomes visible. Otherwise it is probably not worth it.

@jrieken jrieken added this to the March 2019 milestone Mar 26, 2019
@jrieken
Copy link
Member

jrieken commented Mar 27, 2019

Closing as I don't have the information about children until I run the (expensive) call to resolve them. This might change with some API updates but it likely stays like that I would refer to the folder-model here...

@jrieken jrieken closed this as completed Mar 27, 2019
@roblourens
Copy link
Member

It might also look nicer if there is a dummy label like (No children) when I expand an empty child. The first time I saw it I thought I was waiting for data to load.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-symbols definitions, declarations, references under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants