Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call graph: only show source location paths for external callers/callees #71188

Closed
weinand opened this issue Mar 26, 2019 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-symbols definitions, declarations, references under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Mar 26, 2019

testing #71083:

In your sample all callers and callees are located in a single source file. In this case it is very noisy to duplicate the same source path for each node in the call graph:

2019-03-26_16-49-10

I suggest to only show paths for nodes that are outside of the current source file. So in the sample no path would show up.

In a more realistic scenario I could easily see with this approach what part of the call hierarchy is local in the source file and what is external.

@jrieken jrieken added editor-symbols definitions, declarations, references under-discussion Issue is under discussion for relevance, priority, approach labels Mar 26, 2019
@jrieken jrieken modified the milestones: May 2019, March 2019 Mar 26, 2019
@jrieken
Copy link
Member

jrieken commented Mar 26, 2019

The path is actually just a fallback. The api defines CallHierarchyItem#detail and when that's missing it falls back to the filename. The idea is that detail is something like the signature of fully qualified name.

I would just nuke that fallback, showing the symbol name without the filename then.

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Mar 26, 2019
@alexr00 alexr00 added the verified Verification succeeded label Mar 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-symbols definitions, declarations, references under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants