Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify gotoLocation descriptions and values #71240

Closed
chrisdias opened this issue Mar 26, 2019 · 0 comments
Closed

simplify gotoLocation descriptions and values #71240

chrisdias opened this issue Mar 26, 2019 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-symbols definitions, declarations, references polish Cleanup and polish issue verified Verification succeeded
Milestone

Comments

@chrisdias
Copy link
Member

Testing #71087

Add a (default) indicator text to peek which appears to be the default:

Show peek view of the results at the request location (default)

I think the descriptions can be simplified. Assuming these are always on "Go To" actions (given the name of the setting) I suggest using "Go to" instead of "reveal" in the descriptions and also in the values, as that aligns with the command.

Show a peek view of the results (default)
Go to the first results and ignore others
Go to the first result and show a peek view

Suggestions to change the values:

peek -> peek (no change)
reveal -> goto
revealAndPeek -> gotoAndPeek

@jrieken jrieken added this to the March 2019 milestone Mar 27, 2019
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue editor-symbols definitions, declarations, references labels Mar 27, 2019
@Tyriar Tyriar added the verified Verification succeeded label Mar 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-symbols definitions, declarations, references polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants