Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript - perf hooligan #71389

Closed
jrieken opened this issue Mar 28, 2019 · 9 comments
Closed

TypeScript - perf hooligan #71389

jrieken opened this issue Mar 28, 2019 · 9 comments
Assignees
@mjbvz
Labels
extensions Issues concerning extensions freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues info-needed Issue requires more information from poster perf
Milestone
On Deck

Comments

@jrieken
Copy link
Member

jrieken commented Mar 28, 2019 •
edited
Loading

Similar as #71381 and #71290, the TypeScript extension is pretty high up in the list of extensions freezing the extension host. We don't encourage users to file bugs 🤦‍♂️ when it's a built-in extension but we should drill into this...
@jrieken jrieken added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Mar 28, 2019
@jrieken
Copy link
Member Author

jrieken commented Mar 28, 2019

E.g. TypeScript caused 12359 freezes over 5 seconds with 1.32.3. That totals to a lot of time...

@jrieken jrieken added extensions Issues concerning extensions perf labels Mar 28, 2019
@octref
Copy link
Contributor

octref commented Mar 28, 2019

#68896 is possibly related.

@rebornix
Copy link
Member

One side effect I saw is cmd+hover stop working very often. I thought it was mouse event related bug and turns out to be that language service doesn't come back.

@mjbvz mjbvz added this to the April 2019 milestone Apr 1, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 3, 2019

@jrieken Where do we get this data from? I'd like to drill into how many sessions/machines this happens for

@jrieken
Copy link
Member Author

jrieken commented Apr 4, 2019

The telemetry event is exthostunresponsive

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 6, 2019

Seems likely this is the same issue with spawn as in #71290

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 6, 2019

Although this could be #69822

In that case, calls to _convertCompletionItem are taking around 250ms

@mjbvz mjbvz modified the milestones: April 2019, On Deck May 1, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented May 1, 2019

Moving this out since I need a perf log and #69822 doesn't have a response yet

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 26, 2019

Closing as not actionable without a perf profile or repo. I haven't see any user reports of perf problems specific to the TS extension (not the server) but will keep an eye out

@mjbvz mjbvz closed this as completed Jun 26, 2019
@mjbvz mjbvz added the info-needed Issue requires more information from poster label Jun 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
extensions Issues concerning extensions freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues info-needed Issue requires more information from poster perf
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
4 participants
@rebornix @jrieken @octref @mjbvz