Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in custom dialogs should select/copyable #71407

Closed
roblourens opened this issue Mar 28, 2019 · 4 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Text in custom dialogs should select/copyable #71407

roblourens opened this issue Mar 28, 2019 · 4 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
Labels
dialogs Issues with native and custom dialogs feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded web Issues related to running VSCode in the web
Milestone

Comments

@roblourens
Copy link
Member

This is very useful for filing issues with error messages. I can copy text from notifications too.

@sbatten sbatten added feature-request Request for new features or functionality dialogs Issues with native and custom dialogs labels Mar 30, 2019
@sbatten
Copy link
Member

sbatten commented Mar 30, 2019

note this is not a feature of native

@bpasero
Copy link
Member

bpasero commented Aug 23, 2019

What?

image

@bpasero bpasero added the web Issues related to running VSCode in the web label Aug 23, 2019
@sbatten
Copy link
Member

sbatten commented Aug 23, 2019

ah works differently on windows, you can't select the text but if a dialog is focused, ctrl+c copies all its contents in a formatted way

[Window Title]
Visual Studio Code - Insiders

[Main Instruction]
Do you want to save the changes you made to Untitled-1?

[Content]
Your changes will be lost if you don't save them.

[Save] [Don't Save] [Cancel]

I personally don't like when UI lets you select text as it looks unpolished to me, but I can see how it might be of use to select a portion of the dialog. Preference between selection and a single copy action?

@bpasero
Copy link
Member

bpasero commented Aug 24, 2019

Interesting, I did not know that Windows allows you to copy. I find that very hard to discover to be honest. We allow to select and copy in notifications as well so I would go for that.

@sbatten sbatten modified the milestones: On Deck, August 2019 Aug 26, 2019
@sbatten sbatten added the verification-needed Verification of issue is requested label Aug 26, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dialogs Issues with native and custom dialogs feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants