Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting terminal opens default shell instead of current one #73194

Closed
wolf99 opened this issue May 2, 2019 · 1 comment
Closed

Splitting terminal opens default shell instead of current one #73194

wolf99 opened this issue May 2, 2019 · 1 comment
Assignees
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label
Milestone

Comments

@wolf99
Copy link

wolf99 commented May 2, 2019

  • VSCode Version: 1.33.1
  • OS Version: Microsoft Windows 10 1809

Steps to Reproduce:

  1. Open a terminal with a non-default shell - e.g. my default shell in VSCode is cmd, so I would open WSL.
  2. "Split" the terminal using the terminal menu bar icon, or the key shortcut (default is ctrl+)
  3. The default shell, rather than the current shell.

Does this issue occur when all extensions are disabled?: Yes

Ideally the shell already in use in the terminal should be the one used for the split terminal.
On one level the current behaviour kind of makes sense, but is pretty unintuitive.
Also, with this issue in place, I'm actually not sure how else I can get a split terminal with non-default shell in any other than the first split?

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label May 2, 2019
@Tyriar Tyriar added the feature-request Request for new features or functionality label May 3, 2019
@Tyriar Tyriar added this to the Backlog milestone May 3, 2019
@Tyriar
Copy link
Member

Tyriar commented Aug 27, 2021

Closing this out as designed, there are several ways to get the behavior you're after now with the commands and the new + dropdown in the panel. You can also pass args to the newWithProfile command:

image

Additionally there are complications if we allowed splitting the active terminal since it could have been created by an extension and not be a "real" terminal for example.

@Tyriar Tyriar closed this as completed Aug 27, 2021
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Aug 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

2 participants