Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having many file path in terminal output consumes a lot of memory #73802

Closed
fcrick opened this issue May 16, 2019 · 2 comments
Closed

Having many file path in terminal output consumes a lot of memory #73802

fcrick opened this issue May 16, 2019 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label

Comments

@fcrick
Copy link

fcrick commented May 16, 2019

Version: 1.33.1 (user setup)
Commit: 51b0b28
Date: 2019-04-11T08:27:14.102Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134

Steps to Reproduce:

  1. Open VSCode and open new terminal that uses Git bash
  2. Run the command on the next line, and give it a minute or two:

powershell 'dir c: -Directory -Recurse | foreach { $_.FullName }' | while IFS="" read -r p || [ -n "$p" ]; do printf '%s\n' "$p"; sleep .25; done

Does this issue occur when all extensions are disabled?: Yes - still occurs

After 2-3 minutes, vs code will be using tons of ram and cpu, and get really sluggish.
image

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label May 16, 2019
@fcrick
Copy link
Author

fcrick commented May 16, 2019

Note that as this is only printing 4 paths a second, after 3 minutes, that's only 720 paths in terminal output, and yet vscode is using half my cpu and more than a gig of ram - more than a megabyte per path printed.

@Tyriar
Copy link
Member

Tyriar commented May 20, 2019

This looks like an issue with our old terminal backend "winpty", going forward we are focusing our efforts on the new backend "conpty" which is build by the Console team at Microsoft and should fix many issues with the terminal under Windows. You can read more about getting ConPTY here.

/duplicate #45693


I tried to repro this and couldn't, I suspect that's happening is a bunch of redundant data is getting added to the text stream and maybe the terminal can't keep up. If so then this one should fix it xtermjs/xterm.js#2077

@Tyriar Tyriar closed this as completed May 20, 2019
@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label May 20, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

2 participants