Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace characters render over the top of decorations #74187

Closed
DanTup opened this issue May 23, 2019 · 1 comment
Closed

Whitespace characters render over the top of decorations #74187

DanTup opened this issue May 23, 2019 · 1 comment
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-render-whitespace Editor whitespace rendering issues editor-rendering Editor rendering issues feature-request Request for new features or functionality
Milestone

Comments

@DanTup
Copy link
Contributor

DanTup commented May 23, 2019

If you insert some "floating" text using a decorations before/after properties, it's rendered underneath the whitespace markers:

decorations.push({
	range: new vs.Range(
		new vs.Position(line, anchorPoint),
		new vs.Position(line, anchorPoint),
	),
	renderOptions: {
		after: {
			color: "#6666ff",
			contentText: "SOME TEXT",
			width: "0",
		},
	},
});

Screenshot 2019-05-23 at 8 58 16 am

For my real use case, I'm drawing markers between text so it appears like this:

Screenshot 2019-05-23 at 8 53 04 am

I can imagine for some use cases this might be preferred (for ex. things like the indent rainbow extension), but I think it'd also be useful to be able to draw over the top.

@jrieken jrieken assigned rebornix and alexdima and unassigned jrieken May 23, 2019
@alexdima alexdima added editor-rendering Editor rendering issues feature-request Request for new features or functionality labels Jul 24, 2019
@alexdima alexdima added editor-render-whitespace Editor whitespace rendering issues and removed editor-rendering Editor rendering issues labels Oct 25, 2019
@alexdima alexdima added the editor-rendering Editor rendering issues label Feb 4, 2020
@alexdima alexdima removed their assignment Feb 4, 2020
@rebornix rebornix removed their assignment Oct 9, 2020
@rebornix rebornix added this to the Backlog milestone Oct 9, 2020
@alexdima
Copy link
Member

Let's continue tracking in #73780

@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-render-whitespace Editor whitespace rendering issues editor-rendering Editor rendering issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants