Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] Allow to set a background color for settings / webview editors #74342

Open
cyraid opened this issue May 26, 2019 · 6 comments
Open

[themes] Allow to set a background color for settings / webview editors #74342

cyraid opened this issue May 26, 2019 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues
Milestone

Comments

@cyraid
Copy link

cyraid commented May 26, 2019

[Feature Request]
Set background color for generic windows.

[Suggestions]
window.bgColor, settings.bgColor, extensions.bgColor

[Reason]
I love my background color and all, but it only goes well with code.. Because I'm extremely used to a certain color set, but I'd rather separate code and information.

@bpasero
Copy link
Member

bpasero commented May 27, 2019

@cyraid a precise explanation of what you want would certainly help. What is a generic window? What is settings background? What is extensions background color?

If you can draw over a screenshot to explain what you want, even better.

@bpasero bpasero added the info-needed Issue requires more information from poster label May 27, 2019
@cyraid
Copy link
Author

cyraid commented May 27, 2019

Okay, thank you bpasero.

The empty group you were talking about works nicely when there are no windows:

Screenshot 2019-05-27 12 12 50

That is the color I'd like to have all windows except for editing code.

Next, the settings window:

Screenshot 2019-05-27 12 13 05

Notice how the settings have a blue background? It takes from my editor.background.

The extensions window:

Screenshot 2019-05-27 12 13 23

Also takes from my editor.background, but since I use old school borland pascal colors, and have been programming since many ages ago, I'm used to those colors for code.. But not really for anything else (nor does it suit generic information windows).

It would be nice to customize the colors of those windows, and any other informational windows.

@bpasero
Copy link
Member

bpasero commented May 28, 2019

@cyraid so you would like to have 2 new colors: a background color for settings editor and a background color for the rich-editor (not the text editor, but the one that can render rich text)?

@cyraid
Copy link
Author

cyraid commented May 28, 2019

@bpasero yes please. Also fgColor of them too if possible.

@bpasero bpasero added feature-request Request for new features or functionality themes Color theme issues and removed info-needed Issue requires more information from poster labels May 28, 2019
@bpasero bpasero assigned roblourens and mjbvz and unassigned bpasero May 28, 2019
@bpasero bpasero changed the title [FEATURE REQUEST] Settings AND OTHER windows background color Allow to set a background color for settings / webview editors May 28, 2019
@bpasero
Copy link
Member

bpasero commented May 28, 2019

Passing along, not sure if some of this is possible already.

@mjbvz mjbvz assigned aeschli and unassigned mjbvz May 28, 2019
@aeschli aeschli added this to the Backlog milestone Sep 5, 2019
@aeschli aeschli changed the title Allow to set a background color for settings / webview editors [themes] Allow to set a background color for settings / webview editors Oct 10, 2019
@leecookson
Copy link

I am interested in this...many foreground and meta object colors are allowed for settings, but otherwise, the background winds up matching my main edit theme colors. I'd prefer the settings page matches the workbench/list/treecolors.

Specifically, I have a light theme set for the "decorations" of the editor, and a dark theme for specifically the text editor. The settings page winds up with a dark background and oddly low-contrast foreground values, which I assume I'll wind up doing.

Also, if this Issue is resolved, I would like to see "Settings" fall under the "Workbench" category and not "Syntax": (#25986)

@roblourens roblourens assigned rzhao271 and unassigned roblourens Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality themes Color theme issues
Projects
None yet
Development

No branches or pull requests

7 participants