Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification bell icon and the creapy smile need update #74987

Closed
isidorn opened this issue Jun 6, 2019 · 8 comments
Closed

Notification bell icon and the creapy smile need update #74987

isidorn opened this issue Jun 6, 2019 · 8 comments
Assignees
Labels
icons-product Issues for in-product icons
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 6, 2019

Now that my eyes are acustomed to the new lean and hollow icons I am distrubted by the strong notification bell and the feedback smile in the status bar.
I understand they are probably Octicons, but can we find some octicons which fit the new icons better? These now just look out of place

@bpasero

Screenshot 2019-06-06 at 15 51 47

@miguelsolorio
Copy link
Contributor

Status bar icons haven't been updated at all but will be eventually updated.

@isidorn
Copy link
Contributor Author

isidorn commented Jun 6, 2019

Yeah. we can do this next milestone.

@bpasero
Copy link
Member

bpasero commented Jun 6, 2019

@isidorn in what theme is that?

@isidorn
Copy link
Contributor Author

isidorn commented Jun 7, 2019

GitHub Plus while debugging.
Though I was not aiming for the color here, but for the fullnes of the octicons. They should be less heavy.

@bpasero
Copy link
Member

bpasero commented Jun 7, 2019

I am not sure I agree, it looks great for me in the light theme:

image

@isidorn
Copy link
Contributor Author

isidorn commented Jun 7, 2019

@bpasero well that is how they looked from day 1. I am not saying they do not look great, but they look alien compared to the other new icons. No icon we have now is filled and this ones are, doesn't that look odd to you?

@bpasero
Copy link
Member

bpasero commented Jun 7, 2019

Yeah, I think if there is a proposal for changing the octicons I would like to see it in action and then judge based on that.

@miguelsolorio miguelsolorio added the icons-product Issues for in-product icons label Jun 7, 2019
@miguelsolorio miguelsolorio added this to the Backlog milestone Jun 7, 2019
@miguelsolorio
Copy link
Contributor

Closing this in favor of #76909

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
icons-product Issues for in-product icons
Projects
None yet
Development

No branches or pull requests

3 participants