Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables pane does not update after changing value via debug console #75359

Closed
karthiknadig opened this issue Jun 12, 2019 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues release-notes Release notes issues verified Verification succeeded
Milestone

Comments

@karthiknadig
Copy link
Member

Issue Type: Bug
VS Code version: Code 1.35.0 (553cfb2, 2019-06-04T01:17:12.481Z)
OS version: Windows_NT x64 10.0.18362

System Info
Item Value
CPUs Intel(R) Xeon(R) W-2133 CPU @ 3.60GHz (12 x 3600)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.73GB (17.93GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (6)
Extension Author (truncated) Version
python ms- 2019.5.18875
cpptools ms- 0.23.1
csharp ms- 1.19.1
powershell ms- 2019.5.0
vscode-docker Pet 0.6.2
code-spell-checker str 1.7.16

I am from the python extension team. I have investigated this issue on the extension side. The pyhton debug adapter does not get a variables request after a evaluating code via the debug console.

Repro steps:

  1. Create a python file with this content:
a = 1
print(a) # set breakpoint here
  1. After hitting the breakpoint, open debug console and change the value of a
  2. Variables panel is not updated.

image

Logs from the debug adapter

D00027.812: IDE --> {
                "command": "evaluate",
                "arguments": {
                    "expression": "a=5",
                    "frameId": 2,
                    "context": "repl"
                },
                "type": "request",
                "seq": 15
            }

D00027.828: (while handling {'command': 'evaluate', 'type': 'request', 'seq': 15})
            IDE <-- {
                "type": "response",
                "seq": 20,
                "request_seq": 15,
                "success": true,
                "command": "evaluate",
                "message": "",
                "body": {
                    "result": "",
                    "variablesReference": 0,
                    "presentationHint": {}
                }
            }

D00031.844: IDE --> {
                "command": "disconnect",
                "arguments": {
                    "restart": false
                },
                "type": "request",
                "seq": 16
            }

I have looked at the following issues:
#2399
#15520

we are not doing any variable caching on the debug server.

@weinand weinand assigned isidorn and unassigned weinand Jun 12, 2019
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jun 12, 2019
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jun 14, 2019
@isidorn isidorn added this to the June 2019 milestone Jun 14, 2019
@isidorn
Copy link
Contributor

isidorn commented Jun 18, 2019

Try it out in vscode insiders from Wednsdeay and let us know how it behaves for you.
Due to the node limitation specified #15520 we had to introduce some workaround in the variables view (when a variable is changed in the variables view we do not refresh the whole view).
Though this issue as described here should be fixed now.

@RMacfarlane RMacfarlane added the verified Verification succeeded label Jun 26, 2019
@isidorn isidorn added the release-notes Release notes issues label Jun 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues release-notes Release notes issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants