Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Telemetry Command's extension suppot #76057

Closed
3 tasks done
lramos15 opened this issue Jun 25, 2019 · 5 comments
Closed
3 tasks done

Test Telemetry Command's extension suppot #76057

lramos15 opened this issue Jun 25, 2019 · 5 comments

Comments

@lramos15
Copy link
Member

lramos15 commented Jun 25, 2019

Test for #76029

Complexity: 2

  1. Install an extension
  2. Create a file in the extensions installed directory called telemetry.json copy and paste this into it:
{
  "events": {
    "E1" : {
        "E1P1" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
      }
  }
}
  1. Run --telemetry. Ensure that the event shows up under the appropriate extension in the JSON output.
@jrieken jrieken added this to the June 2019 milestone Jun 25, 2019
@alexr00
Copy link
Member

alexr00 commented Jun 25, 2019

@lramos15 are there any other steps? I'm testing on Windows and I just get this:

D:\repos\Microsoft\vscode>code-insiders --telemetry
Unable to read VS Code telemetry events!

D:\repos\Microsoft\vscode>code-insiders . --telemetry
Unable to read VS Code telemetry events!

@lramos15
Copy link
Member Author

lramos15 commented Jun 25, 2019

There's not any other steps and that is just error message given when VS code fails to read either the shipped JSON or the one in the extension folder. I'll investigate this and see what's going on.

@lramos15
Copy link
Member Author

lramos15 commented Jun 25, 2019

@alexr00 The JSON previously provided in the test comment was not valid JSON syntax and therefore was failing when the function tried to parse it. I have updated the example snippet. Please try to run it again with the newly provided snippet and it should work. Sorry about that.

@mjbvz mjbvz removed their assignment Jun 25, 2019
@rebornix
Copy link
Member

rebornix commented Jun 25, 2019

@lramos15 I can still see the same error Unable to read VS Code telemetry events with latest telemetry content on macOS

{
  "events": {
    "E1" : {
        "E1P1" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
      }
  }
}

@alexr00 alexr00 assigned rebornix and unassigned rebornix and alexr00 Jun 26, 2019
@rebornix
Copy link
Member

The reason that it failed on my machine is I have a symlink in the extension folder which now points to a folder no longer exits. As the file doesn't exist,

const dirs = readdirSync(extensionsPath).filter(files => statSync(join(extensionsPath, files)).isDirectory());
throws

@rebornix rebornix removed their assignment Jun 26, 2019
@rebornix rebornix added the verification-needed Verification of issue is requested label Jun 26, 2019
@jrieken jrieken removed the verification-needed Verification of issue is requested label Jun 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants