Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript tsx extension syntax highlighting problem #76327

Closed
b6pzeusbc54tvhw5jgpyw8pwz2x6gs opened this issue Jun 29, 2019 · 3 comments
Closed
Assignees
Labels
grammar Syntax highlighting grammar javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@b6pzeusbc54tvhw5jgpyw8pwz2x6gs
Copy link

b6pzeusbc54tvhw5jgpyw8pwz2x6gs commented Jun 29, 2019

  • VSCode Version: 1.35.1 (1.35.1)
  • OS Version: MacOS 10.14.5

Screen Shot 2019-06-29 at 12 02 14 PM

The last line <TextSmall text={text}/> should be highlighted with the same color as above.

If comment is removed, it works fine:

Screen Shot 2019-06-29 at 12 02 35 PM

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the editor-find Editor find operations label Jun 29, 2019
@mjbvz mjbvz self-assigned this Jun 29, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 1, 2019

Please share the text of the code along with screenshots

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Jul 1, 2019
@b6pzeusbc54tvhw5jgpyw8pwz2x6gs
Copy link
Author

@mjbvz please check it.

const Text: React.FunctionComponent<IProps> = (props) => {
  const { type, text } = props
  return (
      type === 'BIG'      ? <TextBig text={text}/>
    : type === 'BOLD'     ? <TextBold text={text}/>
    : /* type === SMALL */  <TextSmall text={text}/>
  )
}
const Text: React.FunctionComponent<IProps> = (props) => {
  const { type, text } = props
  return (
      type === 'BIG'      ? <TextBig text={text}/>
    : type === 'BOLD'     ? <TextBold text={text}/>
    : <TextSmall text={text}/>
  )
}

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 4, 2019

Thanks. Opened microsoft/TypeScript-TmLanguage#754 to track this upstream

@mjbvz mjbvz closed this as completed Jul 4, 2019
@mjbvz mjbvz added grammar Syntax highlighting grammar javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed editor-find Editor find operations info-needed Issue requires more information from poster labels Jul 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants