Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize env.shell API #76413

Closed
Tyriar opened this issue Jul 1, 2019 · 1 comment · Fixed by #76807
Closed

Finalize env.shell API #76413

Tyriar opened this issue Jul 1, 2019 · 1 comment · Fixed by #76807
Assignees
@Tyriar
Labels
api api-finalization feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 1, 2019

Provided the Python extension uses the API and it works as expected (microsoft/vscode-python#6050), we should finalize it in July.
@Tyriar Tyriar added api terminal Integrated terminal issues api-finalization labels Jul 1, 2019
@Tyriar Tyriar added this to the July 2019 milestone Jul 1, 2019
@Tyriar Tyriar self-assigned this Jul 1, 2019
@Tyriar Tyriar added the feature-request Request for new features or functionality label Jul 1, 2019
@Tyriar Tyriar mentioned this issue Jul 7, 2019
Merged
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jul 29, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Jul 29, 2019

To verify just do a quick test that it seems to be working as expected on any platform, a more thorough test was done in the June milestone.

@jrieken jrieken added the verified Verification succeeded label Jul 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
api api-finalization feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

Successfully merging a pull request may close this issue.

Make vscode.env.shell stable API microsoft/vscode
2 participants
@jrieken @Tyriar