Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff view needs more UX affordance when tabs enabled #7661

Closed
isidorn opened this issue Jun 14, 2016 · 5 comments
Closed

Diff view needs more UX affordance when tabs enabled #7661

isidorn opened this issue Jun 14, 2016 · 5 comments
Assignees
Labels
ux User experience issues workbench-tabs VS Code editor tab issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 14, 2016

Enable tabs and open a diff view. Notice the following:

  1. Diff view is rendered the same as a regular editor view - we should add some affordance so there is a clear difference between the two when looking at the tab header
  2. There are no more top level diff view actions - this is fine as this space is now occupied by tabs - but this actions should be present in the secondary top level actions

screen shot 2016-06-14 at 15 47 55

@isidorn isidorn added the workbench-tabs VS Code editor tab issues label Jun 14, 2016
@bpasero
Copy link
Member

bpasero commented Jun 14, 2016

@isidorn all diff actions should show up in the context menu of the tab.

I agree though that we need to add something to the label to make it clear this is a diff.

@bpasero bpasero added this to the June 2016 milestone Jun 14, 2016
@bpasero bpasero added the ux User experience issues label Jun 14, 2016
@isidorn
Copy link
Contributor Author

isidorn commented Jun 14, 2016

Ok now I found the actions in the context menu - and I agree it makes sense that they live there. It is just me as a user I was acustomed to have those actions in the corner. And I think it will be hard for users to find these actions in their new location.

No idea how to solve this, just saying that some users might not be happy. But it is fine for now :)

@bpasero
Copy link
Member

bpasero commented Jun 14, 2016

You get a LOT when you enable tabs, but you cannot have everything ;). Opened #7666 for that particular issue.

@isidorn
Copy link
Contributor Author

isidorn commented Jun 15, 2016

Not sure if HEAD is needed:

  • just occupies space
  • caps lock -> unnecessery draws attention
  • I think it will be obvious to users if you just show lalalal.txt <-> lalalal.txt

@bpasero
Copy link
Member

bpasero commented Jun 15, 2016

I leave that up to @joaomoreno if he has other ideas how to represent this:

image

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ux User experience issues workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

2 participants