Links in Typescript tooltips don't work

[DanTup]

There are blue hyperlinks in the tooltips for the VS Code bindings, but clicking them doesn't seem to do anything. If they're not expected to work, should they not be links?

[mjbvz]

These links are of the form #Some-Symbol-Name and so they definitely will not work. Support is tracked by #8223

Marking as help wanted if someone want to investigate stripping such links from the displayed content

[DiamondYuan]

These links are of the form #Some-Symbol-Name and so they definitely will not work. Support is tracked by #8223

Marking as help wanted if someone want to investigate stripping such links from the displayed content

i can do this job，Do you mean remove link from comment in image？

[mjbvz]

Yes. Just render it as text

[DiamondYuan]

Yes. Just render it as text

Sorry, I didn't find which file I should change.

[frobinsonj]

Commit 2c1c691 from @jrieken means that these links will now output as file:///#fragment.

Could add || href.match(/^file:\/\/\/#/) to the below if statement to filter out these broken links but that's far from ideal. Would like to have a go at this issue but I have a feeling that a better solution would involve removing "file" as the default scheme. Any ideas on how I could tackle this?

vscode/src/vs/base/browser/markdownRenderer.ts

Lines 101 to 110 in fa5c638

	if (
	!href
	|| href.match(/^data:|javascript:/i)
	|| (href.match(/^command:/i) && !markdown.isTrusted)
	|| href.match(/^command:(\/\/\/)?_workbench\.downloadResource/i)
	) {
	// drop the link
	return text;
	} else {

[bradennapier]

This occurs because there is a special extension that specifically provides document links for any vscode.d.ts files. This is separate from the tooltip renderer which renders the markdown.

It is pretty clear that in general URI fragment should provide a means for navigating to a symbol.

file://path/to/file.ts#Symbol.path should basically be supported out of box.

[mjbvz]

Let's fold this into microsoft/TypeScript#35524

Once JS/TS supports @see tags, then we can swap over to using proper links in the vscode.d.ts file