Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Dynamic SCSS resolver #77539

Closed
3 tasks done
octref opened this issue Jul 17, 2019 · 0 comments
Closed
3 tasks done

Test: Dynamic SCSS resolver #77539

octref opened this issue Jul 17, 2019 · 0 comments

Comments

@octref
Copy link
Contributor

octref commented Jul 17, 2019

Test for #58204

Complexity: 1

Overview

Previously, @import 'foo'; or @import './foo' always resolves to ./_foo.scss.
Now @import 'foo'; resolves to one of these five locations (descending order):

  • foo.scss
  • _foo.scss
  • foo/index.scss
  • foo/_index.scss
  • foo.css

Note that if import relative URL include a leading _ such as _foo or _foo.scss, it only resolves to _foo.scss.
If import relateive URL ends with suffix like .css and .scss, no special resolution is done.

Test

  • @import 'foo' can resolve to anyone of these 5 variations, if the other 4 are not present
  • When multiple ones are present, such as foo.scss and _foo.scss, resolves to the one higher on the list.
@octref octref added this to the July 2019 milestone Jul 17, 2019
@kieferrm kieferrm removed their assignment Jul 31, 2019
@chrisdias chrisdias removed their assignment Jul 31, 2019
@gregvanl gregvanl removed their assignment Jul 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants