Grid state not correctly restored on restart

[alexr00]

Testing #78137

Starting state that I made:

Then I moved one of the sashes:

Then I restarted:

You can see that the sash position didn't save.

[sbatten]

@bpasero where does the editor grid stuff get saved, not sure why it wouldn't be properly saved in grid layout

[bpasero]

@sbatten it gets stored into the memento of the editor part (editorpart.state):

vscode/src/vs/workbench/browser/parts/editor/editorPart.ts

Line 939 in 8ebfa68

protected saveState(): void {

[chpxu]

I have been seeing this issue from time to time especially in the exploration electron 6 builds: my sidebar width still resets on starting up vscode

[bpasero]

@beastdestroyer and what is your setting for workbench.useExperimentalGridLayout?

[chpxu]

@bpasero It has always been on since introduced as a setting

Also for me it seems the sidebar occassionally resets itself too but it isn't consistent

[bpasero]

I would wait for a more recent exploration build where a couple of changes went in specifically around serialization.

[sbatten]

@joaomoreno we can discuss this in our deep dive tomorrow as this results from the many layout calls happening during initial layout propagating down to the nested grid which gets a lot of different sizes ruining its serialized layout.

[joaomoreno]

Only happens for vertical sashes of the editor grid.