Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brackets are drawn in the insider version #78492

Closed
coaperator opened this issue Aug 5, 2019 · 5 comments
Closed

Brackets are drawn in the insider version #78492

coaperator opened this issue Aug 5, 2019 · 5 comments
Assignees

Comments

@coaperator
Copy link

Brackets are drawn in the insider version of VS CODE to fold the code instead of +/-. how to get back into place +/-
change it
image
on this
image

@IllusionMH
Copy link
Contributor

This works as intended and was implemented as part of iconography update #8017 .

These icons (basically collapse, expand) are now unified and used across the app (fold/unfold, Explorer, custom trees etc.)

Not sure if these can be changed as part of theme.

@kanlukasz
Copy link

Icons are redesigned and now everything is consistent
This was the goal that was achieved.

You don't have +/- but you have >/v instead which is readable too

obraz

I do not think that VS Team will change that.
If you get a lot of 👍 here, maybe they'll think about it again, but honestly, I do not think so

@coaperator
Copy link
Author

Nightmare pointers!
Informativeness is zero, because parentheses usually indicate a place, a string. They do not carry information about the blockiness of the code, while +/- precisely indicate the blockiness of the code, that it can be minimized / expanded.

The three most important visual things for me in the editor are:

  • hearth backlight
  • code folding +/- (this is a generally accepted standard for editors)
  • brackets on one line with the code minimized (this is a generally accepted standard for editors)

If the update is accepted and the normal icons (+ and -) are not left - for me this editor is dead.

And what were the hopes.

@octref
Copy link
Contributor

octref commented Aug 5, 2019

I also think while hovering, the icon should change to the down chevron to indicate that the action will "expand":

image

Plus sign was a good indication of the action of expanding.

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Aug 5, 2019

We already have an issue tracking this #78024, please 👍 that issue if you'd like.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants