Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tslint.json should be jsonc #78821

Closed
Tyriar opened this issue Aug 9, 2019 · 2 comments · Fixed by #80048
Closed

tslint.json should be jsonc #78821

Tyriar opened this issue Aug 9, 2019 · 2 comments · Fixed by #80048
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues verified Verification succeeded
Milestone
August 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 9, 2019

Screen Shot 2019-08-09 at 11 10 12 AM

https://palantir.github.io/tslint/usage/configuration/

tslint.json configuration files may have JavaScript-style // single-line and /* multi-line */ comments in them (even though this is technically invalid JSON). If this confuses your syntax highlighter, you may want to switch it to JavaScript format.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues labels Aug 9, 2019
@Tyriar Tyriar added this to the August 2019 milestone Aug 9, 2019
@Tyriar Tyriar closed this as completed in d2ed5fb Aug 9, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 28, 2019 •
edited
Loading

Reopening because I do not think this is a good default. tslint.json files are not full jsonc as they do not support trailing commas: palantir/tslint#1721

I actually reverted treating tslint.json as jsonc in our tslint extension because it is a real pain to track down why tslint is failing due to an extra trailing comma

@mjbvz mjbvz reopened this Aug 28, 2019
@mjbvz mjbvz added the verification-found Issue verification failed label Aug 28, 2019
@aeschli
Copy link
Contributor

aeschli commented Aug 29, 2019 •
edited
Loading

I also suggest we revert. TSLint is soon replaced by eslint anyways.

Will push a fix where only our settings file tolerates trailing commas.

@aeschli aeschli mentioned this issue Aug 29, 2019
Merged
@octref octref added verified Verification succeeded and removed verification-found Issue verification failed labels Aug 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

Successfully merging a pull request may close this issue.

trailing commas only for settings files microsoft/vscode
4 participants
@Tyriar @octref @aeschli @mjbvz