Dialog: opening a dialog without buttons crashes

[bpasero]

Looks like the custom dialog is not fit for when no buttons are provided. I wonder if in that case we should just always provide a default OK button.

TypeError: Cannot read property 'focus' of undefined
    at Promise (:9888/out/vs/base/browser/ui/dialog/dialog.js:154)
    at new Promise (<anonymous>)
    at Dialog.<anonymous> (:9888/out/vs/base/browser/ui/dialog/dialog.js:55)
    at Generator.next (<anonymous>)
    at :9888/out/vs/workbench/browser/web.main.js:10
    at new Promise (<anonymous>)
    at __awaiter (:9888/out/vs/workbench/browser/web.main.js:6)
    at Dialog.show (:9888/out/vs/base/browser/ui/dialog/dialog.js:53)
    at Proxy.<anonymous> (:9888/out/vs/platform/dialogs/browser/dialogService.js:82)
    at Generator.next (<anonymous>)

[sbatten]

@bpasero do you know what the intended dialog was so I can just test what we do with native?

[bpasero]

@sbatten yeah I made the about dialog available to web and simply wanted to test it without any button first. I am not sure native operating systems allow you to actually bring up dialogs without buttons, so having a default OK button seems about right.