New Octicons don't have enough contrast

[miguelsolorio]

Related #76909

Old

New

Bold

This feedback is not around the shape of the icon but the fact that our current octicons all have a solid background applied which puts a very nice contrast on top of the status bar. With the new transparent icons we are loosing this contrast. They almost look like the reverse icon of what we have today (e.g. now transparent where we used to have white background).

Originally posted by @bpasero in #79234 (comment)

[pedily]

I think when they were implemented they were designed and tested on high-dpi screens.
For more "traditional" setups like 24" 1080p, they look blurry because they get antialiased to transparency.

[miguelsolorio]

@strafbier this issue is about Octicons in the status bar and quick pick, not the activity bar.

See this comment about why they appear blurry.

[ErikHumphrey]

The solid icons would be fine if they had the same positioning/height/spacing as New and Bold, rather than appearing as off-center or not taking up enough of the space on the status bar.

[sstaub]

The new icons are horrible designed and not helpful for perception.

[miguelsolorio]

@sstaub can you elaborate? Are you referring to our new icons everywhere or just the Octicons?

[sstaub]

Both, the icons on the sidebar also on the statusbar (insider version).
The buttons and symbols on statusbar and sidebar were better before, because they had a better contrast.
Maybe we can choose between old and new design in settings.

[miguelsolorio]

Thanks everyone for the feedback. In trying to keep our issue count on a manageable level, I'm going to close this issue as a duplicate of #79130 since that will solve this issue. Please upvote the issue there.