Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attaching/detaching from the debug targets #79314

Closed
weinand opened this issue Aug 16, 2019 · 5 comments
Closed

Allow attaching/detaching from the debug targets #79314

weinand opened this issue Aug 16, 2019 · 5 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Aug 16, 2019

This request asks for a lightweight way of attaching/detaching the debugger UI to/from a debug target (in contrast to a heavyweight launch/attach that starts and ends a debug session).

If the debugger UI is detached (in the lightweight way), the debug session will continue to run and the debugger is still in control and can terminate the debuggee, but the debugger will not stop on breakpoints or exceptions because no debugging takes place.

In theory this could be implemented by means of DAP's "attach" and "disconnect" request: a DA is started and attaches to the debug target via the attach request. "Lightweight" detaching disconnects from the debug target via the disconnect request, but the debug adapter continues to run.

@pavelfeldman does this correctly reflect the intent of your item?

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Aug 16, 2019
@weinand weinand added this to the On Deck milestone Aug 16, 2019
@weinand weinand self-assigned this Aug 16, 2019
@weinand weinand modified the milestones: On Deck, November 2019 Oct 24, 2019
@weinand weinand modified the milestones: November 2019, December 2019 Dec 2, 2019
@weinand
Copy link
Contributor Author

weinand commented Dec 11, 2019

@connor4312 @roblourens is this feature something you would consume/support in js-debug anytime soon?

@connor4312
Copy link
Member

While this seems fairly easy to support in js-debug, I'm not sure I really see the use case for this. Were there concrete scenarios we had in mind around it?

@weinand
Copy link
Contributor Author

weinand commented Dec 12, 2019

Pavel brought this up when we discussed the PWA demo:
you can have a long-running debug session (from a VS Code perspective), but a specific target is not affected by debugging at all, as long you are not attached to it (no breakpoints are hit etc.).
Then, when something interesting happens, you can easily attach and gain full control over the target.
Currently, you have to terminate a debug session and start a new (which potentially takes down child processes etc.)

@connor4312
Copy link
Member

I see. That would work well with the "debugger terminal" that js-debug has. We'll need to put some thought into how the user experience works in the editor, but I'd be willing to support it in js-debug.

@weinand weinand modified the milestones: January 2020, On Deck Jan 27, 2020
@weinand weinand added the *out-of-scope Posted issue is not in scope of VS Code label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants
@weinand @connor4312 and others