Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API for extensions to resolve variables in launch.json during resolveDebugConfiguration() #79518

Closed
kejxu opened this issue Aug 20, 2019 · 3 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@kejxu
Copy link

kejxu commented Aug 20, 2019

our debugger extension is going to parse a configuration and propagate the debug requests to language-specific debugger extensions (vscode-python, vscode-cpptools).

for example, for the following configuration

{
    "name": "debug",
    "type": "newtype",
    "request": "launch",
    "target": "${file}"
},

the target ${file} points to an XML file that contains the actual launch requests. We need to actually parse that file and generate debug requests to the other debuggers.

Since we need access to vscode.debug.startDebugging(), this needs to take place inside vscode.DebugConfigurationProvider.resolveDebugConfiguration() (not the debug adapter). For this reason, we need an API to resolve VS Code variables manually (inside the extension's context).

@RMacfarlane RMacfarlane added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Aug 20, 2019
@weinand weinand added this to the On Deck milestone Aug 21, 2019
@weinand weinand modified the milestones: On Deck, January 2020 Jan 8, 2020
@weinand
Copy link
Contributor

weinand commented Jan 8, 2020

We've introduced a new hook resolveDebugConfigurationWithSubstitutedVariables that receives the debug configuration with all variables resolved. See #87450.

@weinand weinand closed this as completed Jan 8, 2020
@weinand
Copy link
Contributor

weinand commented Jan 8, 2020

/duplicate #87450

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 8, 2020
@weinand weinand removed this from the January 2020 milestone Jan 8, 2020
@kejxu
Copy link
Author

kejxu commented Jan 8, 2020

@seanyen

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants
@weinand @RMacfarlane @kejxu and others