Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import changes to TextMate YAML syntax highlighting to fix string literals #79667

Closed
heaths opened this issue Aug 22, 2019 · 5 comments
Closed
Assignees
Labels
grammar Syntax highlighting grammar languages-basic Basic language support issues

Comments

@heaths
Copy link
Member

heaths commented Aug 22, 2019

On VSCode 1.37.1 (f06011a), string literals in YAML aren't treated completely as strings. I opened #54219 a while back but was closed waiting for TextMate to fix this. Based on textmate/yaml.tmbundle#26 it seems that has happened. Can you do an import/conversion and test this?

@RMacfarlane RMacfarlane added the languages-basic Basic language support issues label Aug 22, 2019
@aeschli aeschli assigned alexr00 and unassigned aeschli Aug 23, 2019
@alexr00
Copy link
Member

alexr00 commented Aug 23, 2019

From the other bug:

This is already fixed in TextMate (tested in version 2.0-rc.23). Github uses https://github.com/atom/language-yaml/blob/master/grammars/yaml.cson which also works. I don't know if VSCode supports the CSON format but it should be trivially convertible to VSCode-compatible JSON.

Looks like we need to think about changing to another grammar.

@alexr00 alexr00 added this to the September 2019 milestone Aug 23, 2019
@alexr00 alexr00 added the grammar Syntax highlighting grammar label Aug 23, 2019
@heaths
Copy link
Member Author

heaths commented Aug 23, 2019

Perhaps, but my understanding is that the .tm files from TextMate are converted to JSON. GH is using a different format, sure, but doesn't necessarily indicate you have to use that.

@alexr00
Copy link
Member

alexr00 commented Sep 2, 2019

I tested out https://github.com/atom/language-yaml/blob/master/grammars/yaml.cson and the syntax highlighting we get from that is inferior.
alternateYaml

We have the latest yaml grammar from textmate/yaml.tmbundle already, so it looks like there is still a need for a fix there for textmate/yaml.tmbundle#26

@alexr00 alexr00 closed this as completed Sep 2, 2019
@alexr00 alexr00 removed this from the September 2019 milestone Sep 2, 2019
@heaths
Copy link
Member Author

heaths commented Sep 2, 2019

Please take a look at the comment here: textmate/yaml.tmbundle#26 (comment)

Seems this is already fixed in TextMate. I wasn't suggesting to use CSON.

@alexr00
Copy link
Member

alexr00 commented Sep 2, 2019

We already have the latest from textmate/yaml.tmbundle

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar languages-basic Basic language support issues
Projects
None yet
Development

No branches or pull requests

4 participants