Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown extension is opening thousands of files #79835

Closed
OmarTawfik opened this issue Aug 26, 2019 · 1 comment
Closed

Markdown extension is opening thousands of files #79835

OmarTawfik opened this issue Aug 26, 2019 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@OmarTawfik
Copy link

OmarTawfik commented Aug 26, 2019

  • VSCode Version: latest master

Problem

I've an extension/language server that lints files on file open. The linters are expensive and sometimes take a couple of seconds to run (an external process invocation). Multiple users reported that sometimes their linters would suddenly spike to hundreds/thousands of checks, without the user obviously opening these files.

Root Cause

I tracked it down to the built-in extension markdown-language-features. It performs a local file search on all markdown files in the workspace, ignoring node_modules, then opens each file.

For non Node.js projects, where they keep their build/out files in different folders, this is a huge performance issue. I'm not sure why does it need to open the file in the editor, instead of a file read, but if a user opens a workspace with hundreds/thousands of markdown files, the editor shouldn't try to open all of them!

With this extension activated, the vscode.workspace.onDidOpenTextDocument event is completely ubusable.

@mjbvz mjbvz self-assigned this Aug 26, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 26, 2019

Duplicate of #50874

@mjbvz mjbvz marked this as a duplicate of #50874 Aug 26, 2019
@mjbvz mjbvz closed this as completed Aug 26, 2019
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants