Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple open to the side brings layout in a broken state #79897

Closed
isidorn opened this issue Aug 27, 2019 · 5 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Multiple open to the side brings layout in a broken state #79897

isidorn opened this issue Aug 27, 2019 · 5 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 27, 2019

Refs: #79845

  1. Have a smaller vscode window
  2. Open explorer and start clicking on the Open to the Side context menu command
  3. Every editor is opened in a new group reducing the available horizontal space
  4. When there is no more space the explorer is no longer visible and the layout is in a broken state since I can no longer click on any of the Sashes to resize 🐛

Notice on the gif that I am trying to find the sashes but am not able

openToTheSide

@isidorn
Copy link
Contributor Author

isidorn commented Aug 27, 2019

Note that I can more easily getting into the sashes are broken state by having more than 3 groups side by side. Somehow the sashes are always off then. Adding label bug.

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Aug 27, 2019
@sbatten
Copy link
Member

sbatten commented Aug 27, 2019

Making note of 2 regressions:

  1. Open to side shifts the sidebar out of view
  2. When in the broken state, if you can see the sidebar, the sash is disabled.

The sashes being broken within the editor part is not a regression it seems and we don't handle this super well in stable either, but better than this.

@sbatten sbatten added this to the August 2019 milestone Aug 27, 2019
@sbatten
Copy link
Member

sbatten commented Aug 28, 2019

@isidorn @joaomoreno I've pushed a fix here to make this better, but its not an ideal fix and also doesn't really fix everything. We should probably explore another option next iteration.

@joaomoreno feel free to revert if you think this fix is too hacky to keep

@octref octref added the verified Verification succeeded label Aug 29, 2019
@octref
Copy link
Contributor

octref commented Aug 29, 2019

Sashes now don't show, that's good, but I still want what terminal split does:

image

@sbatten
Copy link
Member

sbatten commented Aug 29, 2019

@octref what makes this tricky today is that the editor can increase its size beyond the currently allotted space and should expand, but agreed that this would be an improvement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants