Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipped error icon in keybindings (JSON) editor #79966

Closed
egamma opened this issue Aug 28, 2019 · 5 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Clipped error icon in keybindings (JSON) editor #79966

egamma opened this issue Aug 28, 2019 · 5 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@egamma
Copy link
Member

egamma commented Aug 28, 2019

image

@miguelsolorio
Copy link
Contributor

@egamma how did you get the icon to show up here?

@miguelsolorio
Copy link
Contributor

@sandy081 why do we use an inline error icon? This doesn't seem like a pattern we use and we typically rely on the error panel/squiggles. I don't see why this should get a special treatment which makes it inconsistent.

@sandy081
Copy link
Member

We validate the keybindings.json content and showing errors, agreed that we should use diagnostics instead. @alexandrudima FYI.

@sandy081 sandy081 assigned alexdima and unassigned sandy081 and miguelsolorio Aug 29, 2019
@alexdima
Copy link
Member

@misolori There are other cases like this one:

image

It is used here as a way to tell you that WYSInotWYG (!WYSIWYG):
image

@alexdima alexdima added this to the August 2019 milestone Aug 29, 2019
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Aug 29, 2019
@miguelsolorio
Copy link
Contributor

@alexandrudima in those cases can we also surface an info/blue squiggle? I think that would help bring more visibility to it.

@octref octref added the verified Verification succeeded label Aug 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants