Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When opening extension URI, URL should be URI, and URI should be shown in full #80002

Closed
octref opened this issue Aug 28, 2019 · 1 comment · Fixed by microsoft/azuredatastudio#7206
Closed

When opening extension URI, URL should be URI, and URI should be shown in full #80002

octref opened this issue Aug 28, 2019 · 1 comment · Fixed by microsoft/azuredatastudio#7206
Assignees
@joaomoreno
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2019

Comments

@octref
Copy link
Contributor

octref commented Aug 28, 2019

Transferred from internal repo, when testing the vscode.env.createAppUri API

image

These are URI not URL. I'm also wondering why we are showing the ... when we have enough space to display the full URI.
@joaomoreno joaomoreno added this to the September 2019 milestone Aug 30, 2019
@joaomoreno joaomoreno added api bug Issue identified by VS Code Team member as probable bug labels Aug 30, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Sep 4, 2019 •
edited
Loading

The cropping is hard since we need to accommodate for all the different dialogs we have: web, mac, win, linux. We simply have to pick a number. We currently crop at 40 characters, since #66628

@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@octref octref added the verified Verification succeeded label Oct 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
3 participants
@joaomoreno @octref @sbatten