Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility word navigation does not handle punctuation well #80223

Closed
isidorn opened this issue Sep 2, 2019 · 10 comments
Closed

Accessibility word navigation does not handle punctuation well #80223

isidorn opened this issue Sep 2, 2019 · 10 comments
Assignees
@isidorn
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *duplicate Issue identified as a duplicate of another issue(s) under-discussion Issue is under discussion for relevance, priority, approach
Milestone
Backlog

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 2, 2019

From @Neurrone

Enter the following line in a file:

a, b

I expect the following sequence to be heard when pressing ctrl+right from the start of the line:

a,
b

Instead, it speaks this:

a,
blank

If the line is modified to a, /b, the first ctrl+right causes an announcement of a, / which is also wrong.
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Sep 2, 2019
@isidorn isidorn added this to the September 2019 milestone Sep 2, 2019
@isidorn isidorn self-assigned this Sep 2, 2019
@isidorn isidorn mentioned this issue Sep 2, 2019
Closed
@isidorn
Copy link
Contributor Author

isidorn commented Oct 2, 2019

@Neurrone I am having some issue with NVDA and VSCode (both insiders and stable) on Windows. When I navigate words the words do not get read out by NVDA. Did NVDA change something that this needs to be enabled? When I navigate using up / down to change lines everything is read out correctly.
I am using NVDA 2019.2.1 and it is always in this "Pending Update" state. What version are you using?
Thanks for the help.

@isidorn isidorn modified the milestones: September 2019, October 2019 Oct 2, 2019
@isidorn isidorn added the info-needed Issue requires more information from poster label Oct 25, 2019
@isidorn
Copy link
Contributor Author

isidorn commented Oct 25, 2019

ping @Neurrone for my question

@isidorn isidorn modified the milestones: October 2019, November 2019 Oct 25, 2019
@Neurrone
Copy link

@isidorn sorry for the late reply. There's a bunch of big refactoring going on in NVDA beyond 2019.1. I'm on the latest alpha version and can't reproduce this issue with the latest VS Code as well.

@isidorn
Copy link
Contributor Author

isidorn commented Nov 11, 2019

@Neurrone thanks for letting me know. Let's close this for now and we can reopen in the future if you encounter it again.

@isidorn isidorn closed this as completed Nov 11, 2019
@Neurrone
Copy link

@isidorn Sorry, I meant that I didn't have trouble with most word navigation, but the test case that I put above can still reproduce the issue.

@isidorn
Copy link
Contributor Author

isidorn commented Nov 11, 2019

Ok, so let's reopen for now. And you can provide more feedback once you use the new NVDA more. Thanks

@isidorn isidorn reopened this Nov 11, 2019
@isidorn isidorn modified the milestones: November 2019, Backlog Nov 11, 2019
@isidorn isidorn added under-discussion Issue is under discussion for relevance, priority, approach and removed bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster labels Nov 11, 2019
@Neurrone
Copy link

The issue should still be reproduceable with the version of NVDA you tested it with, 2019.2.1

@isidorn isidorn mentioned this issue Nov 15, 2019
Merged
@Neurrone
Copy link

CC-ing @derekriemer and @RobGallo

@isidorn I'm now able to semi-reliably reproduce moving up and down lines as well as by word not reading what it should. I'm not sure if this is caused by changes in Vs Code and/or NVDA, and seems to happen more often if my CPU is busy doing something else in the background.

@isidorn
Copy link
Contributor Author

isidorn commented Nov 18, 2019

@Neurrone we did not really change anything with regards to the navigation logic. We only updated to the newest Electron, which in theory could affect this.

Also note that there is a PR open which is trying to tackle this #83450
Maybe we can continue the discussion there. Thanks

@isidorn
Copy link
Contributor Author

isidorn commented Apr 7, 2020

Closing as dup of #90578

@isidorn isidorn closed this as completed Apr 7, 2020
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *duplicate Issue identified as a duplicate of another issue(s) under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@isidorn @Neurrone