Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickopen history is missing #80334

Closed
roblourens opened this issue Sep 4, 2019 · 4 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Quickopen history is missing #80334

roblourens opened this issue Sep 4, 2019 · 4 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
@roblourens @bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2019

Comments

@roblourens
Copy link
Member

  • Open a file
  • Open quick open, that file should be at the top of "Recently opened", but it isn't
@ryanjwessel
Copy link

I noticed the same behavior today after updating. Went through my settings and Search > Quick Open > Include History is enabled. This is my primary method for navigating through multiple files.

@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Sep 4, 2019
@roblourens roblourens added this to the September 2019 milestone Sep 4, 2019
@roblourens
Copy link
Member Author

roblourens commented Sep 4, 2019 •
edited
Loading

Found a fix to get it into the next insiders. @bpasero please look at 3ba84a8. removeFromHistory invalidates the local history

@bpasero
Copy link
Member

bpasero commented Sep 5, 2019

@roblourens thanks, I am not sure what I was thinking there, this strict property work is already causing bugs. I will probably revert that change altogether because it seems quite risky to me to always work on a different history object...

@ryanjwessel
Copy link

Looks like the latest update fixed it. Thanks for addressing this so quickly!

@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@bpasero bpasero added the verified Verification succeeded label Oct 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
3 participants
@roblourens @bpasero @ryanjwessel