Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Icon Uri to refer to microsoft/vscode-icons #80531

Closed
HaaLeo opened this issue Sep 8, 2019 · 1 comment
Closed

Allow Icon Uri to refer to microsoft/vscode-icons #80531

HaaLeo opened this issue Sep 8, 2019 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@HaaLeo
Copy link

HaaLeo commented Sep 8, 2019

Description

As an extension developer I want to use the latest microsoft/vscode-icons in my extension without copying the svg files as resources. I want to be able to do something like:

import * as vscode from 'vscode';

const myButton: vscode.QuickInputButton = {
    iconPath: {
        dark: vscode.Uri.parse('https://raw.githubusercontent.com/microsoft/vscode-icons/master/icons/dark/edit.svg'),
        light: vscode.Uri.parse('https://raw.githubusercontent.com/microsoft/vscode-icons/master/icons/dark/edit.svg')
    },
    tooltip: 'Insert Result'
}

Proposal

Allow the usage of https://raw.githubusercontent.com/microsoft/vscode-icons/... URIs

Related Issues

@miguelsolorio
Copy link
Contributor

I think #31466 will handle this. I don't think we want to link to any external URLs as that will easily break w/ connection issues. Instead we'd likely provide a way to use it similar to Octicons via $(icon-name). Will close this in favor of #31466.

Also, this work will rely on #78889 so keep an eye on that.

@miguelsolorio miguelsolorio added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 9, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants