Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: visual hints for inline breakpoints #81175

Closed
2 tasks done
isidorn opened this issue Sep 19, 2019 · 0 comments
Closed
2 tasks done

Test: visual hints for inline breakpoints #81175

isidorn opened this issue Sep 19, 2019 · 0 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 19, 2019

Refs: #31612

Complexity: 4

Start debugging a node application (for example our express sample) or some Chrome application (for example our Renderer by launching "Debug VSCode Main and Renderer" from vscode repo)

Verify when you add a breakpoint on a line that we:

  • render breakpoint candidate locations in gray
  • breakpoint candidate locations give nice visual feedback so user can easily figure out they are clickable
  • clicking on the candiadte location adds a breakpoin, or if the breakpoint is already there it removes it
  • you can right click on the inline breakpoint and all the actions in the context menu make sense and work as expected
  • making changes to the editor content all the inline breakpoint decoration are nicely moved
  • making any changes to the breakpoints in the BREAKPOINT view nicely updates all the inline breakpoint decorations
  • when you stop debugging, or when you remove breakpoints from a line all the candidate decorations get removed
  • try to be creative and break the decoration UI. Also we were inspired by how Chrome is doing this, so you can always double check how chrome is behaving if you think we are inferior in some cases.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

3 participants